Do you have to be a student in NY to pay the student price or does it go for any student in any state

I only had to make a donation also.

A valid student ID from any state will work. Pay-what-you-wish admission is also available, and gives access to the permanent collection. For access to the special exhibits and Space Show, a +One or +All ticket is required. The student price for these is $22.50 and $27 respectively. https://ticketing.amnh.org/#/tickets

I didn't have to pay anything. But I made a donation. Also, I wasn't a student.

I don't know but if you check the official site you could find all information like this.